aw: Add empty functor detach callback

aw: Add empty functor detach callback

BUG=597167
Committed: https://crrev.com/00fbfa471acddad5cc7c12a5478cde6b082b43a4
Cr-Commit-Position: refs/heads/master@{#386036}

[boliu, 2016-04-08 02:52:19]

boliu@chromium.org changed reviewers:
+ tobiasjs@chromium.org, torne@chromium.org

[boliu, 2016-04-08 02:52:19]

toby: next step is to implement AwContents.onDrawGLFunctorDetached.

torne to review. This should *not* be called from onDetachedFromWindow on N.
Trying to get the glue part in before branch to avoid complicated merges, so
please cq if you approve

[Torne, 2016-04-08 09:41:20]

On 2016/04/08 02:52:19, boliu wrote:
> torne to review. This should *not* be called from onDetachedFromWindow on N.

OK, so this will be safe because all that will happen after the final API is
declared is we can remove this check for being redundant (it'll already be doing
the right thing).

> Trying to get the glue part in before branch to avoid complicated merges, so
> please cq if you approve

LGTM.

[Torne, 2016-04-08 09:41:24]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2016-04-08 09:41:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865313003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865313003/1

[commit-bot: I haz the power, 2016-04-08 10:13:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-08 10:14:29]

Description was changed from

==========
aw: Add empty functor detach callback

BUG=597167
==========

to

==========
aw: Add empty functor detach callback

BUG=597167

Committed: https://crrev.com/00fbfa471acddad5cc7c12a5478cde6b082b43a4
Cr-Commit-Position: refs/heads/master@{#386036}
==========

[commit-bot: I haz the power, 2016-04-08 10:14:31]

Patchset 1 (id:??) landed as
https://crrev.com/00fbfa471acddad5cc7c12a5478cde6b082b43a4
Cr-Commit-Position: refs/heads/master@{#386036}

[boliu, 2016-04-08 16:44:45]

And of course, I forgot corner cases when I add stuff that's not actually being
used. Turns out will need to expose setDrawGlFunctionDetachedCallback to
AwContents (ie non-glue code) to support adding the callback to FullScreenView.
Going to add that bit before branch, which pretty also reverts this CL :p

[boliu, 2016-04-08 16:50:14]

On 2016/04/08 16:44:45, boliu wrote:
> And of course, I forgot corner cases when I add stuff that's not actually
being
> used. Turns out will need to expose setDrawGlFunctionDetachedCallback to
> AwContents (ie non-glue code) to support adding the callback to
FullScreenView.
> Going to add that bit before branch, which pretty also reverts this CL :p

Here: https://codereview.chromium.org/1870163002/

I'll just get toby to stamp it