Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1865293003: [stubs] Introduce DivideStub. (Closed)

Created:
4 years, 8 months ago by epertoso
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Introduce DivideStub. Adds a DivideStub for the division operator and hooks it up with TurboFan and Ignition. Committed: https://crrev.com/f4c4da995471ac2fbc0875c0a5eecd46c212cbd4 Cr-Commit-Position: refs/heads/master@{#35364}

Patch Set 1 #

Patch Set 2 : Updated: make sure labels are bound. #

Total comments: 2

Patch Set 3 : Update. #

Patch Set 4 : Update #

Patch Set 5 : Taking the SMI size into account. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -2 lines) Patch
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 1 chunk +211 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 39 (21 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865293003/1
4 years, 8 months ago (2016-04-07 16:09:27 UTC) #2
epertoso
4 years, 8 months ago (2016-04-07 16:26:10 UTC) #4
Benedikt Meurer
Nice. LGTM with nit. https://codereview.chromium.org/1865293003/diff/20001/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/1865293003/diff/20001/src/code-stubs.cc#newcode1267 src/code-stubs.cc:1267: assembler->Bind(&bailout); Nit: Add { and ...
4 years, 8 months ago (2016-04-08 04:25:03 UTC) #5
epertoso
https://codereview.chromium.org/1865293003/diff/20001/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/1865293003/diff/20001/src/code-stubs.cc#newcode1267 src/code-stubs.cc:1267: assembler->Bind(&bailout); On 2016/04/08 at 04:25:03, Benedikt Meurer wrote: > ...
4 years, 8 months ago (2016-04-08 08:25:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865293003/40001
4 years, 8 months ago (2016-04-08 08:30:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/16398)
4 years, 8 months ago (2016-04-08 08:47:49 UTC) #11
epertoso
PTAL
4 years, 8 months ago (2016-04-08 10:43:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865293003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865293003/60001
4 years, 8 months ago (2016-04-08 10:51:19 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/16326) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-08 10:54:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865293003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865293003/80001
4 years, 8 months ago (2016-04-08 11:13:53 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/18134)
4 years, 8 months ago (2016-04-08 11:26:24 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865293003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865293003/100001
4 years, 8 months ago (2016-04-08 13:46:35 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/16412)
4 years, 8 months ago (2016-04-08 14:02:45 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865293003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865293003/120001
4 years, 8 months ago (2016-04-08 14:30:11 UTC) #31
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 14:50:39 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865293003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865293003/120001
4 years, 8 months ago (2016-04-08 14:51:07 UTC) #36
commit-bot: I haz the power
Committed patchset #5 (id:120001)
4 years, 8 months ago (2016-04-08 14:53:10 UTC) #37
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 14:54:51 UTC) #39
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f4c4da995471ac2fbc0875c0a5eecd46c212cbd4
Cr-Commit-Position: refs/heads/master@{#35364}

Powered by Google App Engine
This is Rietveld 408576698