Issue 186523002: Revert of Move WebAXObjectProxy and AccessibleController from CppBoundClass to gin::Wrappable

Issue 186523002: Revert of Move WebAXObjectProxy and AccessibleController from CppBoundClass to gin::Wrappable (Closed)

Created:
6 years, 9 months ago by apavlov

Modified:
6 years, 9 months ago

Reviewers:
haraken, hajimehoshi, dmazzoni, jochen (gone - plz use gerrit), kouhei (in TOK)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Move WebAXObjectProxy and AccessibleController from CppBoundClass to gin::Wrappable (https://codereview.chromium.org/172263002/) Reason for revert: fast/dom/Window/property-access-on-cached*.html tests (4 in total) assert on debug bots. Original issue's description: > Move WebAXObjectProxy and AccessibleController from CppBoundClass to gin::Wrappable > > BUG=297480, 331301 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253821 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254432 TBR=jochen@chromium.org,kouhei@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,hajimehoshi@chromium.org NOTREECHECKS=true NOTRY=true BUG=297480, 331301 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254735

Patch Set 1 #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1600 lines, -1622 lines)			Patch
M	content/content_shell.gypi	View	3 chunks	+4 lines, -5 lines	0 comments	Download
A	content/shell/renderer/test_runner/AccessibilityController.h	View	1 chunk	+71 lines, -0 lines	0 comments	Download
A	content/shell/renderer/test_runner/AccessibilityController.cpp	View	1 chunk	+184 lines, -0 lines	0 comments	Download
M	content/shell/renderer/test_runner/TestInterfaces.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/shell/renderer/test_runner/TestInterfaces.cpp	View	8 chunks	+9 lines, -9 lines	0 comments	Download
A	content/shell/renderer/test_runner/WebAXObjectProxy.h	View	1 chunk	+146 lines, -0 lines	0 comments	Download
A	content/shell/renderer/test_runner/WebAXObjectProxy.cpp	View	1 chunk	+1178 lines, -0 lines	0 comments	Download
M	content/shell/renderer/test_runner/WebTestProxy.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
D	content/shell/renderer/test_runner/accessibility_controller.h	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	content/shell/renderer/test_runner/accessibility_controller.cc	View	1 chunk	+0 lines, -275 lines	0 comments	Download
D	content/shell/renderer/test_runner/unsafe_persistent.h	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	content/shell/renderer/test_runner/web_ax_object_proxy.h	View	1 chunk	+0 lines, -168 lines	0 comments	Download
D	content/shell/renderer/test_runner/web_ax_object_proxy.cc	View	1 chunk	+0 lines, -1030 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

apavlov

Created Revert of Move WebAXObjectProxy and AccessibleController from CppBoundClass to gin::Wrappable

6 years, 9 months ago (2014-03-04 08:18:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/186523002/1

6 years, 9 months ago (2014-03-04 08:18:40 UTC) #2

apavlov

Reference URL: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2FWindow%2Fproperty-access-on-cached-properties-after-frame-navigated.html

6 years, 9 months ago (2014-03-04 08:19:02 UTC) #3

hajimehoshi

On 2014/03/04 08:19:02, apavlov wrote: > Reference URL: > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%252Fdom%252FWindow%252Fproperty-access-on-cached-properties-after-frame-navigated.html I'm afraid I don't think ...

6 years, 9 months ago (2014-03-04 08:44:37 UTC) #4

haraken

The regression range is r254432 - r254435. http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=254432:254435&mode=html

6 years, 9 months ago (2014-03-04 08:51:13 UTC) #6

hajimehoshi

On 2014/03/04 08:51:13, haraken wrote: > The regression range is r254432 - r254435. > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=254432:254435&mode=html ...

6 years, 9 months ago (2014-03-04 09:26:32 UTC) #7

hajimehoshi

On 2014/03/04 09:26:32, hajimehoshi wrote: > On 2014/03/04 08:51:13, haraken wrote: > > The regression ...

6 years, 9 months ago (2014-03-04 10:44:00 UTC) #8

apavlov

6 years, 9 months ago (2014-03-04 10:45:22 UTC) #9

Message was sent while issue was closed.

On 2014/03/04 10:44:00, hajimehoshi wrote:
> Some of tests are newly added at https://codereview.chromium.org/131113003 and
> these seems to be failing whether or not my CL exists.

Yes, expectation failures are not related to your patch.

Expand Messages | Collapse Messages