Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBFactory.h

Issue 1865213006: Replace setIndexedDBClientCreateFunction madness with Supplements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify per review feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBFactory.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBFactory.h b/third_party/WebKit/Source/modules/indexeddb/IDBFactory.h
index 8b2c0d17c14308e7fe45c94a47162fa97a18700b..49ca639d54468a84a69a570326844822f03e0d87 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBFactory.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBFactory.h
@@ -30,7 +30,6 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "modules/indexeddb/IDBOpenDBRequest.h"
-#include "modules/indexeddb/IndexedDBClient.h"
#include "platform/heap/Handle.h"
#include "wtf/text/WTFString.h"
@@ -42,11 +41,11 @@ class ScriptState;
class IDBFactory final : public GarbageCollected<IDBFactory>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- static IDBFactory* create(IndexedDBClient* client)
+ static IDBFactory* create()
{
- return new IDBFactory(client);
+ return new IDBFactory();
}
- DECLARE_TRACE();
+ DEFINE_INLINE_VIRTUAL_TRACE() { }
IDBRequest* getDatabaseNames(ScriptState*, ExceptionState&);
@@ -57,11 +56,9 @@ public:
short cmp(ScriptState*, const ScriptValue& first, const ScriptValue& second, ExceptionState&);
private:
- explicit IDBFactory(IndexedDBClient*);
+ IDBFactory();
IDBOpenDBRequest* openInternal(ScriptState*, const String& name, int64_t version, ExceptionState&);
-
- Member<IndexedDBClient> m_permissionClient;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698