chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/device_permissions_dialog_view.h ('k') | chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h

diff --git a/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h b/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h

index c16fa8fc5dd91ff0784ba4344cf8001510753293..233ad0468d9df6a0eb9400538543ceb1d9dfedcd 100644

--- a/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h

+++ b/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h

@@ -34,7 +34,7 @@ class ExtensionActionPlatformDelegateViews

// ExtensionActionPlatformDelegate:

void RegisterCommand() override;

void ShowPopup(

- scoped_ptr<extensions::ExtensionViewHost> host,

+ std::unique_ptr<extensions::ExtensionViewHost> host,

bool grant_tab_permissions,

ExtensionActionViewController::PopupShowAction show_action) override;

void CloseOverflowMenu() override;

@@ -61,7 +61,7 @@ class ExtensionActionPlatformDelegateViews

// The extension key binding accelerator this extension action is listening

// for (to show the popup).

- scoped_ptr<ui::Accelerator> action_keybinding_;

+ std::unique_ptr<ui::Accelerator> action_keybinding_;

content::NotificationRegistrar registrar_;