chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc

index 2e3080ee1aeef56e14489692520fd44c10e17887..45c73d60f4743339a49215e8def558e626b5aa2f 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc

@@ -4,9 +4,10 @@

#include "chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h"

+#include <memory>

#include "base/command_line.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "build/build_config.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/extensions/test_extension_service.h"

@@ -59,7 +60,7 @@ IN_PROC_BROWSER_TEST_F(BookmarkBubbleSignInDelegateTest, OnSignInLinkClicked) {

ReplaceBlank(browser());

int starting_tab_count = browser()->tab_strip_model()->count();

- scoped_ptr<BubbleSyncPromoDelegate> delegate;

+ std::unique_ptr<BubbleSyncPromoDelegate> delegate;

delegate.reset(new BookmarkBubbleSignInDelegate(browser()));

delegate->OnSignInLinkClicked();

@@ -76,7 +77,7 @@ IN_PROC_BROWSER_TEST_F(BookmarkBubbleSignInDelegateTest,

OnSignInLinkClickedReusesBlank) {

int starting_tab_count = browser()->tab_strip_model()->count();

- scoped_ptr<BubbleSyncPromoDelegate> delegate;

+ std::unique_ptr<BubbleSyncPromoDelegate> delegate;

delegate.reset(new BookmarkBubbleSignInDelegate(browser()));

delegate->OnSignInLinkClicked();

@@ -98,7 +99,7 @@ IN_PROC_BROWSER_TEST_F(BookmarkBubbleSignInDelegateTest,

int starting_tab_count_incognito =

incognito_browser->tab_strip_model()->count();

- scoped_ptr<BubbleSyncPromoDelegate> delegate;

+ std::unique_ptr<BubbleSyncPromoDelegate> delegate;

delegate.reset(new BookmarkBubbleSignInDelegate(incognito_browser));

delegate->OnSignInLinkClicked();

@@ -126,7 +127,7 @@ IN_PROC_BROWSER_TEST_F(BookmarkBubbleSignInDelegateTest, BrowserRemoved) {

int starting_tab_count = extra_browser->tab_strip_model()->count();

- scoped_ptr<BubbleSyncPromoDelegate> delegate;

+ std::unique_ptr<BubbleSyncPromoDelegate> delegate;

delegate.reset(new BookmarkBubbleSignInDelegate(browser()));

BrowserList::SetLastActive(extra_browser);