chrome/browser/ui/views/desktop_media_picker_views_unittest.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/desktop_media_picker_views_unittest.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/desktop_media_picker_views.cc ('k') | chrome/browser/ui/views/download/download_danger_prompt_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/desktop_media_picker_views_unittest.cc

diff --git a/chrome/browser/ui/views/desktop_media_picker_views_unittest.cc b/chrome/browser/ui/views/desktop_media_picker_views_unittest.cc

index ea05df6bb9c87ffcb2c8c7648c814b5d0c7024de..7ec7fc3814c965d72ecbe27948df837b3380591f 100644

--- a/chrome/browser/ui/views/desktop_media_picker_views_unittest.cc

+++ b/chrome/browser/ui/views/desktop_media_picker_views_unittest.cc

@@ -30,7 +30,7 @@ class DesktopMediaPickerViewsTest : public testing::Test {

void SetUp() override {

media_list_ = new FakeDesktopMediaList();

- scoped_ptr<FakeDesktopMediaList> media_list(media_list_);

+ std::unique_ptr<FakeDesktopMediaList> media_list(media_list_);

base::string16 app_name = base::ASCIIToUTF16("foo");

@@ -58,7 +58,7 @@ class DesktopMediaPickerViewsTest : public testing::Test {

content::TestBrowserThreadBundle thread_bundle_;

views::ScopedViewsTestHelper test_helper_;

FakeDesktopMediaList* media_list_;

- scoped_ptr<DesktopMediaPickerViews> picker_views_;

+ std::unique_ptr<DesktopMediaPickerViews> picker_views_;

};

TEST_F(DesktopMediaPickerViewsTest, DoneCallbackCalledWhenWindowClosed) {