chrome/browser/ui/views/extensions/extension_message_bubble_view.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc ('k') | chrome/browser/ui/views/extensions/extension_message_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_message_bubble_view.h

diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view.h b/chrome/browser/ui/views/extensions/extension_message_bubble_view.h

index e98418976c636f041a71f5bff26c870ae37c9856..91bcd95268d00afaa0dc5734e4779b9ddeb63bc4 100644

--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view.h

+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view.h

@@ -5,8 +5,9 @@

#ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_VIEW_H_

#define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_VIEW_H_

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "ui/views/bubble/bubble_delegate.h"

#include "ui/views/controls/button/button.h"

#include "ui/views/controls/link_listener.h"

@@ -32,7 +33,7 @@ class ExtensionMessageBubbleView : public views::BubbleDelegateView,

ExtensionMessageBubbleView(

views::View* anchor_view,

views::BubbleBorder::Arrow arrow_location,

- scoped_ptr<ExtensionMessageBubbleController> controller);

+ std::unique_ptr<ExtensionMessageBubbleController> controller);

// Shows the bubble after a five-second delay.

void Show();

@@ -62,7 +63,7 @@ class ExtensionMessageBubbleView : public views::BubbleDelegateView,

const ViewHierarchyChangedDetails& details) override;

// The controller for this bubble.

- scoped_ptr<ExtensionMessageBubbleController> controller_;

+ std::unique_ptr<ExtensionMessageBubbleController> controller_;

// The view this bubble is anchored against.

views::View* anchor_view_;