chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc

index 8d9e597c6a751ab542601b96de8321e3b42b9cea..5e06a0e761581c60320013f2759eba2d4586d814 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc

@@ -4,8 +4,9 @@

#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.h"

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/run_loop.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/test_extension_environment.h"

@@ -154,7 +155,7 @@ TEST_F(AppInfoDialogViewsTest, DestroyedProfileClosesDialog) {

// Tests that the dialog does not close when a different profile is destroyed.

TEST_F(AppInfoDialogViewsTest, DestroyedOtherProfileDoesNotCloseDialog) {

- scoped_ptr<TestingProfile> other_profile(new TestingProfile);

+ std::unique_ptr<TestingProfile> other_profile(new TestingProfile);

extension_environment_.CreateExtensionServiceForProfile(other_profile.get());

scoped_refptr<const extensions::Extension> other_app =