chrome/browser/ui/sync/one_click_signin_sync_starter.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.h

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.h b/chrome/browser/ui/sync/one_click_signin_sync_starter.h

index b8b497071adc910c366fb25b2349da0eecd894cf..e95b4bc3f6f0465fb595703e4120cdd65fcc1a1b 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.h

+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.h

@@ -5,12 +5,12 @@

#ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_

#define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_

+#include <memory>

#include <string>

#include "base/callback_forward.h"

#include "base/gtest_prod_util.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser_list_observer.h"

@@ -219,7 +219,7 @@ class OneClickSigninSyncStarter : public SigninTracker::Observer,

Profile* profile_;

Browser* browser_;

- scoped_ptr<SigninTracker> signin_tracker_;

+ std::unique_ptr<SigninTracker> signin_tracker_;

StartSyncMode start_mode_;

ConfirmationRequired confirmation_required_;

GURL current_url_;