chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/sync/one_click_signin_bubble_view.h ('k') | chrome/browser/ui/views/sync/one_click_signin_bubble_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

diff --git a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

index ae30b7c461ed0364cf6f4c97aa84cbd83ca2e306..fb007f727c3047d0c2ccd07975e1f49dcde950dd 100644

--- a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

+++ b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

@@ -54,7 +54,7 @@ void OneClickSigninBubbleView::ShowBubble(

BrowserWindow::OneClickSigninBubbleType type,

const base::string16& email,

const base::string16& error_message,

- scoped_ptr<OneClickSigninBubbleDelegate> delegate,

+ std::unique_ptr<OneClickSigninBubbleDelegate> delegate,

views::View* anchor_view,

const BrowserWindow::StartSyncCallback& start_sync) {

if (IsShowing())

@@ -95,7 +95,7 @@ void OneClickSigninBubbleView::Hide() {

OneClickSigninBubbleView::OneClickSigninBubbleView(

const base::string16& error_message,

const base::string16& email,

- scoped_ptr<OneClickSigninBubbleDelegate> delegate,

+ std::unique_ptr<OneClickSigninBubbleDelegate> delegate,

views::View* anchor_view,

const BrowserWindow::StartSyncCallback& start_sync_callback,

bool is_sync_dialog)