Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index b784e4383b95280c33f610290977e47c5a31100a..13af4c444318e67b7c02cb8b4ac6f0d87334990d 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -110,13 +110,12 @@ views::Widget* TranslateBubbleView::ShowBubble(
ChromeTranslateClient::GetTranslateLanguages(
web_contents, &source_language, &target_language);
- scoped_ptr<translate::TranslateUIDelegate> ui_delegate(
+ std::unique_ptr<translate::TranslateUIDelegate> ui_delegate(
new translate::TranslateUIDelegate(
ChromeTranslateClient::GetManagerFromWebContents(web_contents)
->GetWeakPtr(),
- source_language,
- target_language));
- scoped_ptr<TranslateBubbleModel> model(
+ source_language, target_language));
+ std::unique_ptr<TranslateBubbleModel> model(
new TranslateBubbleModelImpl(step, std::move(ui_delegate)));
TranslateBubbleView* view = new TranslateBubbleView(
anchor_view, std::move(model), error_type, web_contents);
@@ -243,7 +242,7 @@ TranslateBubbleModel::ViewState TranslateBubbleView::GetViewState() const {
TranslateBubbleView::TranslateBubbleView(
views::View* anchor_view,
- scoped_ptr<TranslateBubbleModel> model,
+ std::unique_ptr<TranslateBubbleModel> model,
translate::TranslateErrors::Type error_type,
content::WebContents* web_contents)
: LocationBarBubbleDelegateView(anchor_view, web_contents),

Powered by Google App Engine
This is Rietveld 408576698