chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/search/search_webstore_result.cc ('k') | chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc

diff --git a/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc b/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc

index 6329248712dc6ee7e32d2b73386364e13b7f7ae2..aa73e192c532d1d59f66cd1a5c7704bdd697adfb 100644

--- a/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc

+++ b/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc

@@ -4,9 +4,9 @@

#include "chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.h"

+#include <memory>

#include <utility>

-#include "base/memory/scoped_ptr.h"

#include "base/strings/string16.h"

#include "chrome/browser/favicon/favicon_service_factory.h"

#include "chrome/browser/profiles/profile.h"

@@ -51,9 +51,9 @@ void SuggestionsSearchProvider::Start(bool /*is_voice_query*/,

suggestions_profile.suggestions(i);

// TODO(mathp): If it's an app, create an AppResult.

- scoped_ptr<URLSuggestionResult> result(new URLSuggestionResult(

- profile_, list_controller_, favicon_service_, suggestions_service_,

- suggestion));

+ std::unique_ptr<URLSuggestionResult> result(

+ new URLSuggestionResult(profile_, list_controller_, favicon_service_,

+ suggestions_service_, suggestion));

result->set_relevance(1.0 / (i + 1));

Add(std::move(result));

}