chrome/browser/ui/translate/translate_bubble_model_impl.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/translate/translate_bubble_model_impl.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/translate/language_combobox_model.h ('k') | chrome/browser/ui/translate/translate_bubble_model_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/translate/translate_bubble_model_impl.h

diff --git a/chrome/browser/ui/translate/translate_bubble_model_impl.h b/chrome/browser/ui/translate/translate_bubble_model_impl.h

index 48e8a26864088f47411483002b2174dc98e895be..d5219c2b47dac7ad65417eb56ee14615ae0ad887 100644

--- a/chrome/browser/ui/translate/translate_bubble_model_impl.h

+++ b/chrome/browser/ui/translate/translate_bubble_model_impl.h

@@ -5,8 +5,9 @@

#ifndef CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_MODEL_IMPL_H_

#define CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_MODEL_IMPL_H_

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "chrome/browser/translate/chrome_translate_client.h"

#include "chrome/browser/ui/translate/translate_bubble_model.h"

#include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h"

@@ -20,7 +21,7 @@ class TranslateBubbleModelImpl : public TranslateBubbleModel {

public:

TranslateBubbleModelImpl(

translate::TranslateStep step,

- scoped_ptr<translate::TranslateUIDelegate> ui_delegate);

+ std::unique_ptr<translate::TranslateUIDelegate> ui_delegate);

~TranslateBubbleModelImpl() override;

// Converts a TranslateStep to a ViewState.

@@ -50,7 +51,7 @@ class TranslateBubbleModelImpl : public TranslateBubbleModel {

bool IsPageTranslatedInCurrentLanguages() const override;

private:

- scoped_ptr<translate::TranslateUIDelegate> ui_delegate_;

+ std::unique_ptr<translate::TranslateUIDelegate> ui_delegate_;

TranslateBubbleViewStateTransition view_state_transition_;

bool translation_declined_;