chrome/browser/ui/pdf/adobe_reader_info_win.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/pdf/adobe_reader_info_win.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/passwords_client_ui_delegate.h ('k') | chrome/browser/ui/pdf/pdf_unsupported_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/pdf/adobe_reader_info_win.cc

diff --git a/chrome/browser/ui/pdf/adobe_reader_info_win.cc b/chrome/browser/ui/pdf/adobe_reader_info_win.cc

index 86feb5f8f24639ef04f16836b3e532e9ac0d6477..f0187de82b2925d81f2ba64cf789c55b00fa8398 100644

--- a/chrome/browser/ui/pdf/adobe_reader_info_win.cc

+++ b/chrome/browser/ui/pdf/adobe_reader_info_win.cc

@@ -81,7 +81,7 @@ AdobeReaderPluginInfo GetReaderPlugin(

if (std::find_if(plugin.mime_types.begin(), plugin.mime_types.end(),

IsPdfMimeType) == plugin.mime_types.end())

continue;

- scoped_ptr<PluginMetadata> plugin_metadata(

+ std::unique_ptr<PluginMetadata> plugin_metadata(

plugin_finder->GetPluginMetadata(plugins[i]));

if (plugin_metadata->identifier() != kAdobeReaderIdentifier)

continue;

@@ -170,7 +170,7 @@ bool IsAdobeReaderUpToDate() {

if (!is_default)

return false;

- scoped_ptr<FileVersionInfo> file_version_info(

+ std::unique_ptr<FileVersionInfo> file_version_info(

FileVersionInfo::CreateFileVersionInfo(install_path));

if (!file_version_info)

return false;

« no previous file with comments | « chrome/browser/ui/passwords/passwords_client_ui_delegate.h ('k') | chrome/browser/ui/pdf/pdf_unsupported_feature.cc » ('j') | no next file with comments »