chrome/browser/ui/extensions/extension_action_platform_delegate.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_action_platform_delegate.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/application_launch.cc ('k') | chrome/browser/ui/extensions/extension_action_view_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_action_platform_delegate.h

diff --git a/chrome/browser/ui/extensions/extension_action_platform_delegate.h b/chrome/browser/ui/extensions/extension_action_platform_delegate.h

index 9fb4b2617ece5338253bbf08fb566f89075d3362..c6579dac469b95906a7547e142b1fbe738e1ff01 100644

--- a/chrome/browser/ui/extensions/extension_action_platform_delegate.h

+++ b/chrome/browser/ui/extensions/extension_action_platform_delegate.h

@@ -19,7 +19,7 @@ class ExtensionActionPlatformDelegate {

// Returns a created ExtensionActionPlatformDelegate. This is defined in the

// platform-specific implementation for the class.

- static scoped_ptr<ExtensionActionPlatformDelegate> Create(

+ static std::unique_ptr<ExtensionActionPlatformDelegate> Create(

ExtensionActionViewController* controller);

// The following are forwarded from ToolbarActionViewController. See that

@@ -33,7 +33,7 @@ class ExtensionActionPlatformDelegate {

// permissions should be given to the extension; this is only true if the

// popup is opened through a user action.

virtual void ShowPopup(

- scoped_ptr<extensions::ExtensionViewHost> host,

+ std::unique_ptr<extensions::ExtensionViewHost> host,

bool grant_tab_permissions,

ExtensionActionViewController::PopupShowAction show_action) = 0;