chrome/browser/ui/passwords/password_dialog_controller.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/password_dialog_controller.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/password_bubble_experiment_unittest.cc ('k') | chrome/browser/ui/passwords/password_dialog_controller_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/password_dialog_controller.h

diff --git a/chrome/browser/ui/passwords/password_dialog_controller.h b/chrome/browser/ui/passwords/password_dialog_controller.h

index a0c488c334a043daf2adbff8de52f8d6980d5f4e..02b0fc447f2a57ee80a125501947f452a8e02f56 100644

--- a/chrome/browser/ui/passwords/password_dialog_controller.h

+++ b/chrome/browser/ui/passwords/password_dialog_controller.h

@@ -5,10 +5,10 @@

#ifndef CHROME_BROWSER_UI_PASSWORDS_PASSWORD_DIALOG_CONTROLLER_H_

#define CHROME_BROWSER_UI_PASSWORDS_PASSWORD_DIALOG_CONTROLLER_H_

+#include <memory>

#include <utility>

#include <vector>

-#include "base/memory/scoped_ptr.h"

#include "base/strings/string16.h"

#include "components/password_manager/core/common/credential_manager_types.h"

#include "ui/gfx/range/range.h"

@@ -21,7 +21,7 @@ struct PasswordForm;

// and retrieving the state.

class PasswordDialogController {

public:

- using FormsVector = std::vector<scoped_ptr<autofill::PasswordForm>>;

+ using FormsVector = std::vector<std::unique_ptr<autofill::PasswordForm>>;

// Returns forms from the password database for the current site.

virtual const FormsVector& GetLocalForms() const = 0;