chrome/browser/ui/toolbar/toolbar_actions_model.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model.h ('k') | chrome/browser/ui/toolbar/toolbar_actions_model_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/toolbar_actions_model.cc

diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model.cc b/chrome/browser/ui/toolbar/toolbar_actions_model.cc

index 8b8077ba35d8ba0ed3fd2b41285a30540818822f..c60bbeb38352a7bd1fbe34d13f4a5e23b1327bba 100644

--- a/chrome/browser/ui/toolbar/toolbar_actions_model.cc

+++ b/chrome/browser/ui/toolbar/toolbar_actions_model.cc

@@ -172,11 +172,11 @@ ScopedVector<ToolbarActionViewController> ToolbarActionsModel::CreateActions(

return action_list;

}

-scoped_ptr<ToolbarActionViewController>

+std::unique_ptr<ToolbarActionViewController>

ToolbarActionsModel::CreateActionForItem(Browser* browser,

ToolbarActionsBar* bar,

const ToolbarItem& item) {

- scoped_ptr<ToolbarActionViewController> result;

+ std::unique_ptr<ToolbarActionViewController> result;

switch (item.type) {

case EXTENSION_ACTION: {

// Get the extension.

« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model.h ('k') | chrome/browser/ui/toolbar/toolbar_actions_model_factory.h » ('j') | no next file with comments »