chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm ('k') | chrome/browser/ui/cocoa/global_error_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

index ab2e53635bc98d3c0b069ddc9265c97e05081602..5cdf5b88128fef16407e99412b8516748c3dad3e 100644

--- a/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

@@ -25,7 +25,7 @@ void TestingShowAppListInstallDialogController(

WindowedInstallDialogController** controller,

ExtensionInstallPromptShowParams* show_params,

const ExtensionInstallPrompt::DoneCallback& done_callback,

- scoped_ptr<ExtensionInstallPrompt::Prompt> prompt) {

+ std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt) {

*controller =

new WindowedInstallDialogController(show_params, done_callback,

std::move(prompt));

@@ -40,7 +40,7 @@ IN_PROC_BROWSER_TEST_F(WindowedInstallDialogControllerBrowserTest,

ShowInstallDialog) {

// Construct a prompt with a NULL parent window, the way ExtensionEnableFlow

// will for the Mac app list. For testing, sets a NULL PageNavigator as well.

- scoped_ptr<ExtensionInstallPrompt> prompt(

+ std::unique_ptr<ExtensionInstallPrompt> prompt(

new ExtensionInstallPrompt(browser()->profile(), NULL));

WindowedInstallDialogController* controller = NULL;