chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/signin/inline_login_handler_impl.h ('k') | chrome/browser/ui/webui/signin/login_ui_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

index 9cb75d86a45cc9851abc7e3ab2f300a5cdbd00cd..3bab360d898cf778b0c13c03fd50940fd9d0d505 100644

--- a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

@@ -508,7 +508,8 @@ class InlineLoginHelperBrowserTest : public InProcessBrowserTest {

net::TestURLFetcherFactory url_fetcher_factory_;

FakeSigninManagerForTesting* signin_manager_;

FakeProfileOAuth2TokenService* token_service_;

- scoped_ptr<base::CallbackList<void(content::BrowserContext*)>::Subscription>

+ std::unique_ptr<

+ base::CallbackList<void(content::BrowserContext*)>::Subscription>

will_create_browser_context_services_subscription_;

DISALLOW_COPY_AND_ASSIGN(InlineLoginHelperBrowserTest);

@@ -797,7 +798,7 @@ class InlineLoginUISafeIframeBrowserTest : public InProcessBrowserTest {

}

FooWebUIProvider foo_provider_;

- scoped_ptr<TestChromeWebUIControllerFactory> test_factory_;

+ std::unique_ptr<TestChromeWebUIControllerFactory> test_factory_;

};

// Make sure that the foo webui handler is working properly and that it gets