chrome/browser/ui/global_error/global_error_service_browsertest.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/global_error/global_error_service_browsertest.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_controller.h ('k') | chrome/browser/ui/global_error/global_error_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/global_error/global_error_service_browsertest.cc

diff --git a/chrome/browser/ui/global_error/global_error_service_browsertest.cc b/chrome/browser/ui/global_error/global_error_service_browsertest.cc

index e06bd3ec7a15c1d97ec5417d98fbb0024256f290..8ce652662a57fedf99d20013a9f2e04a7c75cda1 100644

--- a/chrome/browser/ui/global_error/global_error_service_browsertest.cc

+++ b/chrome/browser/ui/global_error/global_error_service_browsertest.cc

@@ -4,8 +4,9 @@

#include "chrome/browser/ui/global_error/global_error_service.h"

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "build/build_config.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/global_error/global_error.h"

@@ -120,7 +121,7 @@ IN_PROC_BROWSER_TEST_F(GlobalErrorServiceBrowserTest, CloseBubbleView) {

#endif

IN_PROC_BROWSER_TEST_F(GlobalErrorServiceBrowserTest,

MAYBE_BubbleViewDismissedOnRemove) {

- scoped_ptr<BubbleViewError> error(new BubbleViewError);

+ std::unique_ptr<BubbleViewError> error(new BubbleViewError);

GlobalErrorService* service =

GlobalErrorServiceFactory::GetForProfile(browser()->profile());