chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/applescript/window_applescript.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm

diff --git a/chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm b/chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm

index b78eebbd42759d0b409b63db9410c56db992d618..d9beca195a95ba5d12fab937d5f6ccedb50538cc 100644

--- a/chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm

+++ b/chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm

@@ -8,10 +8,11 @@

#include <stddef.h>

#include <stdint.h>

+#include <memory>

#include "base/json/json_reader.h"

#include "base/mac/scoped_aedesc.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

@@ -235,7 +236,8 @@ TEST_F(AppleEventUtilTest, ValueToAppleEventDescriptor) {

};

for (size_t i = 0; i < arraysize(cases); ++i) {

- scoped_ptr<base::Value> value = base::JSONReader::Read(cases[i].json_input);

+ std::unique_ptr<base::Value> value =

+ base::JSONReader::Read(cases[i].json_input);

NSAppleEventDescriptor* descriptor =

chrome::mac::ValueToAppleEventDescriptor(value.get());