Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: chrome/browser/ui/chrome_bubble_manager_unittest.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/certificate_dialogs.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/chrome_bubble_manager_unittest.cc
diff --git a/chrome/browser/ui/chrome_bubble_manager_unittest.cc b/chrome/browser/ui/chrome_bubble_manager_unittest.cc
index 4e51a95c639221008aab96fc531bb22cab2bef7a..7848085053953fe5926ec43051ae95d2d92ce073 100644
--- a/chrome/browser/ui/chrome_bubble_manager_unittest.cc
+++ b/chrome/browser/ui/chrome_bubble_manager_unittest.cc
@@ -24,7 +24,7 @@ class ChromeBubbleManagerTest : public BrowserWithTestWindowTest {
void TearDown() override;
protected:
- scoped_ptr<ChromeBubbleManager> manager_;
+ std::unique_ptr<ChromeBubbleManager> manager_;
private:
DISALLOW_COPY_AND_ASSIGN(ChromeBubbleManagerTest);
@@ -60,7 +60,7 @@ TEST_F(ChromeBubbleManagerTest, CloseMockBubbleForTwoDifferentReasons) {
TEST_F(ChromeBubbleManagerTest, CloseMockBubbleOnNavigate) {
AddTab(browser(), GURL("https://foo/0"));
- scoped_ptr<MockBubbleDelegate> delegate(new MockBubbleDelegate);
+ std::unique_ptr<MockBubbleDelegate> delegate(new MockBubbleDelegate);
EXPECT_CALL(*delegate, ShouldClose(BUBBLE_CLOSE_NAVIGATED))
.WillOnce(testing::Return(true));
EXPECT_CALL(*delegate, DidClose(BUBBLE_CLOSE_NAVIGATED));
@@ -88,7 +88,7 @@ TEST_F(ChromeBubbleManagerTest, CloseMockBubbleOnOwningFrameDestroy) {
content::RenderFrameHostTester* subframe1_tester =
content::RenderFrameHostTester::For(subframe1);
- scoped_ptr<MockBubbleDelegate> delegate(new MockBubbleDelegate);
+ std::unique_ptr<MockBubbleDelegate> delegate(new MockBubbleDelegate);
EXPECT_CALL(*delegate, OwningFrame())
.WillRepeatedly(testing::Return(subframe0));
EXPECT_CALL(*delegate, ShouldClose(BUBBLE_CLOSE_FRAME_DESTROYED))
« no previous file with comments | « chrome/browser/ui/certificate_dialogs.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698