chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

index e9063864de7941034c24bc6aed1da64c165b44bb..588533de16384be6ab745fbd10c8a24232901f4c 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

@@ -56,7 +56,7 @@ class ExtensionInstallViewDelegate {

Profile* profile_; // weak

content::PageNavigator* navigator_; // weak

ExtensionInstallViewDelegate* delegate_; // weak

- scoped_ptr<ExtensionInstallPrompt::Prompt> prompt_;

+ std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt_;

base::scoped_nsobject<NSArray> warnings_;

BOOL isComputingRowHeight_;

@@ -78,7 +78,7 @@ class ExtensionInstallViewDelegate {

- (id)initWithProfile:(Profile*)profile

navigator:(content::PageNavigator*)navigator

delegate:(ExtensionInstallViewDelegate*)delegate

- prompt:(scoped_ptr<ExtensionInstallPrompt::Prompt>)prompt;

+ prompt:(std::unique_ptr<ExtensionInstallPrompt::Prompt>)prompt;

- (IBAction)storeLinkClicked:(id)sender; // Callback for "View details" link.

- (IBAction)cancel:(id)sender;

- (IBAction)ok:(id)sender;