chrome/browser/ui/tab_helpers.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 906defa417a34a2321036a13dbd348bc3751a847..24a889a975c0ac9ecf35b43a4e2073a5aef66dff 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -192,9 +192,8 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

HungPluginTabHelper::CreateForWebContents(web_contents);

ManagePasswordsUIController::CreateForWebContents(web_contents);

pdf::PDFWebContentsHelper::CreateForWebContentsWithClient(

- web_contents,

- scoped_ptr<pdf::PDFWebContentsHelperClient>(

- new ChromePDFWebContentsHelperClient()));

+ web_contents, std::unique_ptr<pdf::PDFWebContentsHelperClient>(

+ new ChromePDFWebContentsHelperClient()));

PermissionBubbleManager::CreateForWebContents(web_contents);

PluginObserver::CreateForWebContents(web_contents);

SadTabHelper::CreateForWebContents(web_contents);

« no previous file with comments | « chrome/browser/ui/tab_dialogs.h ('k') | chrome/browser/ui/tabs/pinned_tab_codec.cc » ('j') | no next file with comments »