chrome/browser/ui/webui/extensions/extension_loader_handler.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_loader_handler.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_loader_handler.h ('k') | chrome/browser/ui/webui/extensions/extension_settings_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_loader_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_loader_handler.cc b/chrome/browser/ui/webui/extensions/extension_loader_handler.cc

index cf0d61a672275287652688981393852ce3566c2d..af139b8330dacdbb954ca867530dc218a101bd73 100644

--- a/chrome/browser/ui/webui/extensions/extension_loader_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_loader_handler.cc

@@ -186,13 +186,14 @@ void ExtensionLoaderHandler::AddFailure(

failed_paths_.push_back(file_path);

base::FilePath prettified_path = path_util::PrettifyPath(file_path);

- scoped_ptr<base::DictionaryValue> manifest_value(new base::DictionaryValue());

+ std::unique_ptr<base::DictionaryValue> manifest_value(

+ new base::DictionaryValue());

SourceHighlighter highlighter(manifest, line_number);

// If the line number is 0, this highlights no regions, but still adds the

// full manifest.

highlighter.SetHighlightedRegions(manifest_value.get());

- scoped_ptr<base::DictionaryValue> failure(new base::DictionaryValue());

+ std::unique_ptr<base::DictionaryValue> failure(new base::DictionaryValue());

failure->Set("path",

new base::StringValue(prettified_path.LossyDisplayName()));

failure->Set("error", new base::StringValue(base::UTF8ToUTF16(error)));