chrome/browser/ui/views/extensions/extension_popup.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_message_bubble_view.cc ('k') | chrome/browser/ui/views/extensions/extension_popup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_popup.h

diff --git a/chrome/browser/ui/views/extensions/extension_popup.h b/chrome/browser/ui/views/extensions/extension_popup.h

index 1ddbf6f1fe8274aabe3501001ce81f47066056e8..af79bdf78010e423cfde329d0b992960aa702215 100644

--- a/chrome/browser/ui/views/extensions/extension_popup.h

+++ b/chrome/browser/ui/views/extensions/extension_popup.h

@@ -51,7 +51,7 @@ class ExtensionPopup : public views::BubbleDialogDelegateView,

// The actual display of the popup is delayed until the page contents

// finish loading in order to minimize UI flashing and resizing.

static ExtensionPopup* ShowPopup(

- scoped_ptr<extensions::ExtensionViewHost> host,

+ std::unique_ptr<extensions::ExtensionViewHost> host,

views::View* anchor_view,

views::BubbleBorder::Arrow arrow,

ShowAction show_action);

@@ -110,7 +110,7 @@ class ExtensionPopup : public views::BubbleDialogDelegateView,

void OnDevToolsStateChanged(content::DevToolsAgentHost*, bool attached);

// The contained host for the view.

- scoped_ptr<extensions::ExtensionViewHost> host_;

+ std::unique_ptr<extensions::ExtensionViewHost> host_;

// Flag used to indicate if the pop-up should open a devtools window once

// it is shown inspecting it.