Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6128)

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel.h ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel.cc
diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc
index c75c320827aeae68af04f0333ddff06936cdb989..3427d2a935de1ac81f00a2797377861fddeff346 100644
--- a/chrome/browser/ui/panels/panel.cc
+++ b/chrome/browser/ui/panels/panel.cc
@@ -66,7 +66,7 @@ class PanelExtensionWindowController : public extensions::WindowController {
const extensions::Extension* extension) const override;
base::DictionaryValue* CreateTabValue(const extensions::Extension* extension,
int tab_index) const override;
- scoped_ptr<extensions::api::tabs::Tab> CreateTabObject(
+ std::unique_ptr<extensions::api::tabs::Tab> CreateTabObject(
const extensions::Extension* extension,
int tab_index) const override;
bool CanClose(Reason* reason) const override;
@@ -118,7 +118,7 @@ base::DictionaryValue* PanelExtensionWindowController::CreateTabValue(
return CreateTabObject(extension, tab_index)->ToValue().release();
}
-scoped_ptr<extensions::api::tabs::Tab>
+std::unique_ptr<extensions::api::tabs::Tab>
PanelExtensionWindowController::CreateTabObject(
const extensions::Extension* extension,
int tab_index) const {
@@ -129,7 +129,7 @@ PanelExtensionWindowController::CreateTabObject(
if (!web_contents)
return nullptr;
- scoped_ptr<extensions::api::tabs::Tab> tab_object(
+ std::unique_ptr<extensions::api::tabs::Tab> tab_object(
new extensions::api::tabs::Tab);
tab_object->id.reset(new int(SessionTabHelper::IdForTab(web_contents)));
tab_object->index = 0;
« no previous file with comments | « chrome/browser/ui/panels/panel.h ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698