chrome/browser/ui/webui/options/sync_setup_handler.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/sync_setup_handler.h ('k') | chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/sync_setup_handler.cc

diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.cc b/chrome/browser/ui/webui/options/sync_setup_handler.cc

index 1caaea05d4572363466203f7cd281c4c12baa74a..32fa4578add0b5d89b136431046c3021e658e0ad 100644

--- a/chrome/browser/ui/webui/options/sync_setup_handler.cc

+++ b/chrome/browser/ui/webui/options/sync_setup_handler.cc

@@ -94,7 +94,7 @@ SyncConfigInfo::SyncConfigInfo()

SyncConfigInfo::~SyncConfigInfo() {}

bool GetConfiguration(const std::string& json, SyncConfigInfo* config) {

- scoped_ptr<base::Value> parsed_value = base::JSONReader::Read(json);

+ std::unique_ptr<base::Value> parsed_value = base::JSONReader::Read(json);

base::DictionaryValue* result;

if (!parsed_value || !parsed_value->GetAsDictionary(&result)) {

DLOG(ERROR) << "GetConfiguration() not passed a Dictionary";