chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm

index 45eb8da6520f7c64b05a3a30a15877dbcb7d1195..8c5991c93ac1b473f74a222a84e1857dde006eb4 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm

@@ -2,14 +2,17 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#import "chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h"

#import <Cocoa/Cocoa.h>

#include <stddef.h>

+#include <memory>

#include "base/command_line.h"

#include "base/files/file_path.h"

#include "base/files/file_util.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/path_service.h"

#include "base/values.h"

#include "chrome/browser/extensions/api/commands/command_service.h"

@@ -17,7 +20,6 @@

#include "chrome/browser/extensions/test_extension_system.h"

#include "chrome/browser/ui/browser_window.h"

#import "chrome/browser/ui/cocoa/cocoa_profile_test.h"

-#import "chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h"

#import "chrome/browser/ui/cocoa/info_bubble_window.h"

#include "chrome/browser/ui/extensions/extension_installed_bubble.h"

#include "chrome/browser/ui/location_bar/location_bar.h"

@@ -176,7 +178,7 @@ class ExtensionInstalledBubbleControllerTest : public CocoaProfileTest {

scoped_refptr<Extension> extension_;

// The bubble that tests are run on.

- scoped_ptr<ExtensionInstalledBubble> extensionBubble_;

+ std::unique_ptr<ExtensionInstalledBubble> extensionBubble_;

// The icon_ to be loaded into the bubble window.

SkBitmap icon_;