chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/infobars/translate_infobar_base.h ('k') | chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

diff --git a/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm b/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

index 2bdc727f5414588110b8faedc8211e263dc7c7d2..dfcd720c06012c6f7b12341dafb08855c77391ef 100644

--- a/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

+++ b/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

@@ -32,9 +32,9 @@ using InfoBarUtilities::VerifyControlOrderAndSpacing;

using InfoBarUtilities::CreateLabel;

using InfoBarUtilities::AddMenuItem;

-scoped_ptr<infobars::InfoBar> ChromeTranslateClient::CreateInfoBar(

- scoped_ptr<translate::TranslateInfoBarDelegate> delegate) const {

- scoped_ptr<InfoBarCocoa> infobar(new InfoBarCocoa(std::move(delegate)));

+std::unique_ptr<infobars::InfoBar> ChromeTranslateClient::CreateInfoBar(

+ std::unique_ptr<translate::TranslateInfoBarDelegate> delegate) const {

+ std::unique_ptr<InfoBarCocoa> infobar(new InfoBarCocoa(std::move(delegate)));

base::scoped_nsobject<TranslateInfoBarControllerBase> infobar_controller;

switch (infobar->delegate()->AsTranslateInfoBarDelegate()->translate_step()) {

case translate::TRANSLATE_STEP_BEFORE_TRANSLATE: