chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/account_avatar_fetcher_manager.mm ('k') | chrome/browser/ui/cocoa/passwords/auto_signin_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

index c8ef42ecaa8931082494f29ee73acc29f830061f..4629120b71d1402b278088d585e7da12df661661 100644

--- a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

@@ -46,8 +46,9 @@ namespace {

const char kDialogTitle[] = "Choose an account";

// Returns a PasswordForm with only a username.

-scoped_ptr<autofill::PasswordForm> Credential(const char* username) {

- scoped_ptr<autofill::PasswordForm> credential(new autofill::PasswordForm);

+std::unique_ptr<autofill::PasswordForm> Credential(const char* username) {

+ std::unique_ptr<autofill::PasswordForm> credential(

+ new autofill::PasswordForm);

credential->username_value = base::ASCIIToUTF16(username);

return credential;

}

@@ -175,7 +176,7 @@ TEST_F(AccountChooserViewControllerTest, ConfiguresFederatedCredential) {

TEST_F(AccountChooserViewControllerTest, ForwardsAvatarFetchToManager) {

PasswordDialogController::FormsVector local_forms;

- scoped_ptr<autofill::PasswordForm> form = Credential("taco");

+ std::unique_ptr<autofill::PasswordForm> form = Credential("taco");

form->icon_url = GURL("http://foo.com");

local_forms.push_back(std::move(form));

SetUpAccountChooser(&local_forms);