chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/panels/panel_stack_window_cocoa.h ('k') | chrome/browser/ui/cocoa/passwords/account_avatar_fetcher_manager.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h

diff --git a/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h b/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h

index 3ca0211bb1dcd16cd86ccf9c9617e8aedeb73d6a..ea3cf815be0fbc4d04df6b2060bc95dd3141d5b0 100644

--- a/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h

+++ b/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h

@@ -11,8 +11,9 @@

#import <Cocoa/Cocoa.h>

+#include <memory>

#include "base/mac/scoped_nsobject.h"

-#include "base/memory/scoped_ptr.h"

#import "chrome/browser/ui/cocoa/chrome_browser_window.h"

#include "chrome/browser/ui/panels/panel.h"

#import "ui/base/cocoa/tracking_area.h"

@@ -29,7 +30,7 @@ class PanelCocoa;

NSAnimationDelegate> {

@private

IBOutlet PanelTitlebarViewCocoa* titlebar_view_;

- scoped_ptr<PanelCocoa> windowShim_;

+ std::unique_ptr<PanelCocoa> windowShim_;

base::scoped_nsobject<NSString> pendingWindowTitle_;

NSViewAnimation* boundsAnimation_; // Lifetime controlled manually, needs

// more then just |release| to terminate.