chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.h ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm

index 13a628c7032e60fca90942d6b3bc24896e760b01..981860b0c52bd229f1a5d347c03ccb683ad134e9 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm

@@ -112,9 +112,8 @@ TEST_F(BookmarkBarBridgeTest, TestRedirect) {

base::scoped_nsobject<FakeBookmarkBarController> controller(

[[FakeBookmarkBarController alloc] initWithBrowser:browser()]);

EXPECT_TRUE(controller.get());

- scoped_ptr<BookmarkBarBridge> bridge(new BookmarkBarBridge(profile(),

- controller.get(),

- model));

+ std::unique_ptr<BookmarkBarBridge> bridge(

+ new BookmarkBarBridge(profile(), controller.get(), model));

EXPECT_TRUE(bridge.get());

bridge->BookmarkModelLoaded(NULL, false);

« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.h ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h » ('j') | no next file with comments »