chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h

index 310c2717011d337f33882aafe6b9dfd42aa63a4a..1b8514d7f8e5919adb8524b557845591bf7dbd29 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h

@@ -7,8 +7,9 @@

#import <Cocoa/Cocoa.h>

+#include <memory>

#include "base/mac/scoped_nsobject.h"

-#include "base/memory/scoped_ptr.h"

#include "chrome/browser/ui/bookmarks/bookmark_editor.h"

#include "components/bookmarks/browser/bookmark_expanded_state_tracker.h"

@@ -49,7 +50,7 @@ class BookmarkModel;

// there should only ever be one.

base::scoped_nsobject<NSArray> tableSelectionPaths_;

// C++ bridge object that observes the BookmarkModel for me.

- scoped_ptr<BookmarkEditorBaseControllerBridge> observer_;

+ std::unique_ptr<BookmarkEditorBaseControllerBridge> observer_;

}

@property(nonatomic, copy) NSString* initialName;