chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm ('k') | chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

index ff5088970c423cb10ce364e889b19d0eb3721f90..1881dbd08964024fc45009fe572db4f070f092e9 100644

--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

@@ -9,6 +9,7 @@

#include "base/bind.h"

#import "base/mac/mac_util.h"

#include "base/macros.h"

+#include "base/memory/ptr_util.h"

#include "chrome/browser/ssl/ssl_client_certificate_selector.h"

#include "chrome/browser/ssl/ssl_client_certificate_selector_test.h"

#include "chrome/browser/ui/browser.h"

@@ -75,7 +76,7 @@ IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, DISABLED_Basic) {

[SSLClientCertificateSelectorCocoa alloc]

initWithBrowserContext:web_contents->GetBrowserContext()

certRequestInfo:auth_requestor_->cert_request_info_.get()

- delegate:make_scoped_ptr(new TestClientCertificateDelegate(

+ delegate:base::WrapUnique(new TestClientCertificateDelegate(

&destroyed))];

[selector displayForWebContents:web_contents];

content::RunAllPendingInMessageLoop();

@@ -99,7 +100,7 @@ IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, HideShow) {

[SSLClientCertificateSelectorCocoa alloc]

initWithBrowserContext:web_contents->GetBrowserContext()

certRequestInfo:auth_requestor_->cert_request_info_.get()

- delegate:make_scoped_ptr(

+ delegate:base::WrapUnique(

new TestClientCertificateDelegate(nullptr))];

[selector displayForWebContents:web_contents];

content::RunAllPendingInMessageLoop();