chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

index c9839291d3eb3f737fe560431b3f1dc9ed0320b2..09d33204c36abfb047c45e34d167811c154ec46d 100644

--- a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

+++ b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

@@ -183,7 +183,8 @@ IN_PROC_BROWSER_TEST_P(NativeAppWindowCocoaBrowserTest,

g_browser_process->platform_part()->app_shim_host_manager());

MockExtensionAppShimHandler* mock = new MockExtensionAppShimHandler();

test_api.SetExtensionAppShimHandler(

- scoped_ptr<apps::ExtensionAppShimHandler>(mock)); // Takes ownership.

+ std::unique_ptr<apps::ExtensionAppShimHandler>(

+ mock)); // Takes ownership.

MockAppShimHost mock_host;

SetUpAppWithWindows(1);