chrome/browser/ui/webui/popular_sites_internals_message_handler.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/popular_sites_internals_message_handler.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/popular_sites_internals_message_handler.h ('k') | chrome/browser/ui/webui/print_preview/extension_printer_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/popular_sites_internals_message_handler.cc

diff --git a/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc b/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc

index c5f4bbe10f543764ceeffa25365e3ab179b0f265..d6a1c3bcea7547bed209d94c47a7f15433bb9747 100644

--- a/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc

+++ b/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc

@@ -106,9 +106,9 @@ void PopularSitesInternalsMessageHandler::SendDownloadResult(bool success) {

}

void PopularSitesInternalsMessageHandler::SendSites() {

- scoped_ptr<base::ListValue> sites_list(new base::ListValue);

+ std::unique_ptr<base::ListValue> sites_list(new base::ListValue);

for (const PopularSites::Site& site : popular_sites_->sites()) {

- scoped_ptr<base::DictionaryValue> entry(new base::DictionaryValue);

+ std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue);

entry->SetString("title", site.title);

entry->SetString("url", site.url.spec());

sites_list->Append(std::move(entry));