chrome/browser/ui/cocoa/panels/panel_cocoa.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/panels/panel_cocoa.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h ('k') | chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/panels/panel_cocoa.h

diff --git a/chrome/browser/ui/cocoa/panels/panel_cocoa.h b/chrome/browser/ui/cocoa/panels/panel_cocoa.h

index 7d24746ad0515ad88dc252d201fd0ca56a8755b2..67169750a2fd76d9181d587c6b1a5f353d9a83a3 100644

--- a/chrome/browser/ui/cocoa/panels/panel_cocoa.h

+++ b/chrome/browser/ui/cocoa/panels/panel_cocoa.h

@@ -6,9 +6,11 @@

#define CHROME_BROWSER_UI_COCOA_PANELS_PANEL_COCOA_H_

#import <Foundation/Foundation.h>

+#include <memory>

#include "base/gtest_prod_util.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "chrome/browser/ui/panels/native_panel.h"

#include "ui/gfx/geometry/rect.h"

@@ -92,7 +94,7 @@ class PanelCocoa : public NativePanel {

void setBoundsInternal(const gfx::Rect& bounds, bool animate);

- scoped_ptr<Panel> panel_;

+ std::unique_ptr<Panel> panel_;

PanelWindowControllerCocoa* controller_; // Weak, owns us.

// These use platform-independent screen coordinates, with (0,0) at