chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

index d98d88b963da29b31b0de663bc34fa031ede23a1..2a27bac5f26809561dca49963b93fd4318a507ff 100644

--- a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

@@ -410,7 +410,7 @@ void CoreChromeOSOptionsHandler::OnPreferenceChanged(

void CoreChromeOSOptionsHandler::NotifySettingsChanged(

const std::string& setting_name) {

DCHECK(CrosSettings::Get()->IsCrosSettings(setting_name));

- scoped_ptr<base::Value> value(FetchPref(setting_name));

+ std::unique_ptr<base::Value> value(FetchPref(setting_name));

if (!value.get())

NOTREACHED();

DispatchPrefChangeNotification(setting_name, std::move(value));

@@ -423,7 +423,7 @@ void CoreChromeOSOptionsHandler::NotifyProxyPrefsChanged() {

proxy_cros_settings_parser::GetProxyPrefValue(

proxy_config_service_, kProxySettings[i], &value);

DCHECK(value);

- scoped_ptr<base::Value> ptr(value);

+ std::unique_ptr<base::Value> ptr(value);

DispatchPrefChangeNotification(kProxySettings[i], std::move(ptr));

}