chrome/browser/ui/webui/translate_internals/translate_internals_handler.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/translate_internals/translate_internals_handler.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/theme_source_unittest.cc ('k') | chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/translate_internals/translate_internals_handler.h

diff --git a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.h b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.h

index 12a25c84557edacf2518378fcf0c020e49661924..7293dc6740466044d17480fa523fda9ae2a1f9cd 100644

--- a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.h

+++ b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.h

@@ -5,11 +5,11 @@

#ifndef CHROME_BROWSER_UI_WEBUI_TRANSLATE_INTERNALS_TRANSLATE_INTERNALS_HANDLER_H_

#define CHROME_BROWSER_UI_WEBUI_TRANSLATE_INTERNALS_TRANSLATE_INTERNALS_HANDLER_H_

+#include <memory>

#include <string>

#include "base/callback_list.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "components/translate/core/browser/translate_language_list.h"

#include "components/translate/core/browser/translate_manager.h"

#include "content/public/browser/notification_observer.h"

@@ -77,11 +77,12 @@ class TranslateInternalsHandler : public content::WebUIMessageHandler,

void SendSupportedLanguagesToJs();

// Subscription for translate events coming from the translate language list.

- scoped_ptr<translate::TranslateLanguageList::EventCallbackList::Subscription>

+ std::unique_ptr<

+ translate::TranslateLanguageList::EventCallbackList::Subscription>

event_subscription_;

// Subscription for translate errors coming from the translate manager.

- scoped_ptr<

+ std::unique_ptr<

translate::TranslateManager::TranslateErrorCallbackList::Subscription>

error_subscription_;