chrome/browser/ui/views/confirm_bubble_views_unittest.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/confirm_bubble_views_unittest.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/confirm_bubble_views.cc ('k') | chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/confirm_bubble_views_unittest.cc

diff --git a/chrome/browser/ui/views/confirm_bubble_views_unittest.cc b/chrome/browser/ui/views/confirm_bubble_views_unittest.cc

index 206dbef981c6c211cc4ffc1948b14897cf3b03c2..bd22c207ebae363f4d22a73a727d6dfc6af52b2f 100644

--- a/chrome/browser/ui/views/confirm_bubble_views_unittest.cc

+++ b/chrome/browser/ui/views/confirm_bubble_views_unittest.cc

@@ -24,13 +24,13 @@ TEST_F(ConfirmBubbleViewsTest, CreateAndClose) {

// Create parent widget, as confirm bubble must have an owner.

Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_WINDOW);

params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;

- scoped_ptr<views::Widget> parent_widget(new Widget);

+ std::unique_ptr<views::Widget> parent_widget(new Widget);

parent_widget->Init(params);

parent_widget->Show();

// Bubble owns the model.

bool model_deleted = false;

- scoped_ptr<TestConfirmBubbleModel> model(

+ std::unique_ptr<TestConfirmBubbleModel> model(

new TestConfirmBubbleModel(&model_deleted, NULL, NULL, NULL));

ConfirmBubbleViews* bubble = new ConfirmBubbleViews(std::move(model));

gfx::NativeWindow parent = parent_widget->GetNativeWindow();