Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/ui/android/autofill/autofill_dialog_result.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/autofill/autofill_dialog_result.h" 5 #include "chrome/browser/ui/android/autofill/autofill_dialog_result.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_array.h" 8 #include "base/android/jni_array.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 20 matching lines...) Expand all
31 : base::string16(); 31 : base::string16();
32 } 32 }
33 33
34 #define FETCH_JFIELD(env, jobj, cls, getter) \ 34 #define FETCH_JFIELD(env, jobj, cls, getter) \
35 (Java_##cls##_get##getter((env), (jobj))) 35 (Java_##cls##_get##getter((env), (jobj)))
36 36
37 #define FETCH_JSTRING(utf, env, jobj, cls, getter) \ 37 #define FETCH_JSTRING(utf, env, jobj, cls, getter) \
38 (ConvertNullOrJavaStringTo##utf( \ 38 (ConvertNullOrJavaStringTo##utf( \
39 (env), FETCH_JFIELD((env), (jobj), cls, getter).obj())) 39 (env), FETCH_JFIELD((env), (jobj), cls, getter).obj()))
40 40
41 scoped_ptr<wallet::Address> ParseJavaWalletAddress( 41 std::unique_ptr<wallet::Address> ParseJavaWalletAddress(JNIEnv* env,
42 JNIEnv* env, jobject address) { 42 jobject address) {
43 if (!address) 43 if (!address)
44 return scoped_ptr<wallet::Address>(); 44 return std::unique_ptr<wallet::Address>();
45 45
46 const base::string16 recipient_name = 46 const base::string16 recipient_name =
47 FETCH_JSTRING(UTF16, env, address, ResultAddress, Name); 47 FETCH_JSTRING(UTF16, env, address, ResultAddress, Name);
48 48
49 const base::string16 street_address = 49 const base::string16 street_address =
50 FETCH_JSTRING(UTF16, env, address, ResultAddress, StreetAddress); 50 FETCH_JSTRING(UTF16, env, address, ResultAddress, StreetAddress);
51 std::vector<base::string16> address_lines = base::SplitString( 51 std::vector<base::string16> address_lines = base::SplitString(
52 street_address, base::string16(1, '\n'), 52 street_address, base::string16(1, '\n'),
53 base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); 53 base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
54 54
55 const base::string16 locality_name = 55 const base::string16 locality_name =
56 FETCH_JSTRING(UTF16, env, address, ResultAddress, Locality); 56 FETCH_JSTRING(UTF16, env, address, ResultAddress, Locality);
57 const base::string16 dependent_locality_name = 57 const base::string16 dependent_locality_name =
58 FETCH_JSTRING(UTF16, env, address, ResultAddress, DependentLocality); 58 FETCH_JSTRING(UTF16, env, address, ResultAddress, DependentLocality);
59 const base::string16 administrative_area_name = 59 const base::string16 administrative_area_name =
60 FETCH_JSTRING(UTF16, env, address, ResultAddress, AdministrativeArea); 60 FETCH_JSTRING(UTF16, env, address, ResultAddress, AdministrativeArea);
61 const base::string16 postal_code_number = 61 const base::string16 postal_code_number =
62 FETCH_JSTRING(UTF16, env, address, ResultAddress, PostalCode); 62 FETCH_JSTRING(UTF16, env, address, ResultAddress, PostalCode);
63 const base::string16 sorting_code = 63 const base::string16 sorting_code =
64 FETCH_JSTRING(UTF16, env, address, ResultAddress, SortingCode); 64 FETCH_JSTRING(UTF16, env, address, ResultAddress, SortingCode);
65 const base::string16 phone_number = 65 const base::string16 phone_number =
66 FETCH_JSTRING(UTF16, env, address, ResultAddress, PhoneNumber); 66 FETCH_JSTRING(UTF16, env, address, ResultAddress, PhoneNumber);
67 const std::string country_name_code = 67 const std::string country_name_code =
68 FETCH_JSTRING(UTF8, env, address, ResultAddress, CountryCode); 68 FETCH_JSTRING(UTF8, env, address, ResultAddress, CountryCode);
69 DCHECK(!country_name_code.empty()); 69 DCHECK(!country_name_code.empty());
70 const std::string language_code = 70 const std::string language_code =
71 FETCH_JSTRING(UTF8, env, address, ResultAddress, LanguageCode); 71 FETCH_JSTRING(UTF8, env, address, ResultAddress, LanguageCode);
72 72
73 return scoped_ptr<wallet::Address>(new wallet::Address( 73 return std::unique_ptr<wallet::Address>(new wallet::Address(
74 country_name_code, 74 country_name_code, recipient_name, address_lines, locality_name,
75 recipient_name, 75 dependent_locality_name, administrative_area_name, postal_code_number,
76 address_lines, 76 sorting_code, phone_number, std::string(), language_code));
77 locality_name,
78 dependent_locality_name,
79 administrative_area_name,
80 postal_code_number,
81 sorting_code,
82 phone_number,
83 std::string(),
84 language_code));
85 } 77 }
86 78
87 scoped_ptr<wallet::FullWallet> ParseJavaWallet(JNIEnv* env, jobject wallet) { 79 std::unique_ptr<wallet::FullWallet> ParseJavaWallet(JNIEnv* env,
80 jobject wallet) {
88 const ScopedJavaLocalRef<jobject> billing_address( 81 const ScopedJavaLocalRef<jobject> billing_address(
89 FETCH_JFIELD(env, wallet, ResultWallet, BillingAddress)); 82 FETCH_JFIELD(env, wallet, ResultWallet, BillingAddress));
90 const ScopedJavaLocalRef<jobject> shipping_address( 83 const ScopedJavaLocalRef<jobject> shipping_address(
91 FETCH_JFIELD(env, wallet, ResultWallet, ShippingAddress)); 84 FETCH_JFIELD(env, wallet, ResultWallet, ShippingAddress));
92 const ScopedJavaLocalRef<jobject> card( 85 const ScopedJavaLocalRef<jobject> card(
93 FETCH_JFIELD(env, wallet, ResultWallet, Card)); 86 FETCH_JFIELD(env, wallet, ResultWallet, Card));
94 87
95 const int expiration_month = 88 const int expiration_month =
96 FETCH_JFIELD(env, card.obj(), ResultCard, ExpirationMonth); 89 FETCH_JFIELD(env, card.obj(), ResultCard, ExpirationMonth);
97 const int expiration_year = 90 const int expiration_year =
(...skipping 19 matching lines...) Expand all
117 std::string ParseGoogleTransactionId(JNIEnv* env, jobject wallet) { 110 std::string ParseGoogleTransactionId(JNIEnv* env, jobject wallet) {
118 return FETCH_JSTRING(UTF8, env, wallet, ResultWallet, GoogleTransactionId); 111 return FETCH_JSTRING(UTF8, env, wallet, ResultWallet, GoogleTransactionId);
119 } 112 }
120 113
121 #undef FETCH_JSTRING 114 #undef FETCH_JSTRING
122 #undef FETCH_FIELD 115 #undef FETCH_FIELD
123 116
124 } // namespace 117 } // namespace
125 118
126 // static 119 // static
127 scoped_ptr<wallet::FullWallet> AutofillDialogResult::ConvertFromJava( 120 std::unique_ptr<wallet::FullWallet> AutofillDialogResult::ConvertFromJava(
128 JNIEnv* env, jobject wallet) { 121 JNIEnv* env,
122 jobject wallet) {
129 return ParseJavaWallet(env, wallet); 123 return ParseJavaWallet(env, wallet);
130 } 124 }
131 125
132 // static 126 // static
133 base::string16 AutofillDialogResult::GetWalletEmail( 127 base::string16 AutofillDialogResult::GetWalletEmail(
134 JNIEnv* env, jobject wallet) { 128 JNIEnv* env, jobject wallet) {
135 return ParseWalletEmail(env, wallet); 129 return ParseWalletEmail(env, wallet);
136 } 130 }
137 131
138 // static 132 // static
139 std::string AutofillDialogResult::GetWalletGoogleTransactionId( 133 std::string AutofillDialogResult::GetWalletGoogleTransactionId(
140 JNIEnv* env, jobject wallet) { 134 JNIEnv* env, jobject wallet) {
141 return ParseGoogleTransactionId(env, wallet); 135 return ParseGoogleTransactionId(env, wallet);
142 } 136 }
143 137
144 // static 138 // static
145 bool AutofillDialogResult::RegisterAutofillDialogResult(JNIEnv* env) { 139 bool AutofillDialogResult::RegisterAutofillDialogResult(JNIEnv* env) {
146 return RegisterNativesImpl(env); 140 return RegisterNativesImpl(env);
147 } 141 }
148 142
149 } // namespace autofill 143 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698