media/filters/h264_bit_reader.cc - Issue 1865203002: Avoid integer overflow errors when parsing Exp-Golomb codes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/h264_bit_reader.cc

Issue 1865203002: Avoid integer overflow errors when parsing Exp-Golomb codes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 1u Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/h264_bit_reader.cc

diff --git a/media/filters/h264_bit_reader.cc b/media/filters/h264_bit_reader.cc

index 5b009a18281408ad4345e529e706de959a1bb5f8..0830a2896e1ecf987a1652f7077853a2575e0485 100644

--- a/media/filters/h264_bit_reader.cc

+++ b/media/filters/h264_bit_reader.cc

@@ -79,7 +79,7 @@ bool H264BitReader::ReadBits(int num_bits, int* out) {

}

*out |= (curr_byte_ >> (num_remaining_bits_in_curr_byte_ - bits_left));

- *out &= ((1 << num_bits) - 1);

+ *out &= ((1u << num_bits) - 1);

sandersd (OOO until July 31) 2016/04/07 20:48:09 Both should be 1u.

jrummell 2016/04/07 21:13:59 Done.

num_remaining_bits_in_curr_byte_ -= bits_left;

return true;

« no previous file with comments | « no previous file | media/filters/h264_parser.cc » ('j') | media/filters/h264_parser.cc » ('J')