Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1865183002: disable unused argument warning for clang builds. (Closed)

Created:
4 years, 8 months ago by fbarchard1
Modified:
4 years, 8 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

disable unused argument warning for clang builds. normally this warning is disabled but for nacl builds that use clang its not. this CL makes the option universally disabled for all clang based builds. BUG=libyuv:581 TESTED=native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0 & ninja -C out/Debug libyuv R=kjellander@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/2c77dbb976071c5185fca4ab475e72a2975b3993

Patch Set 1 #

Patch Set 2 : add bug=581 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M libyuv.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
kjellander_chromium
lgtm
4 years, 8 months ago (2016-04-10 18:13:44 UTC) #2
fbarchard1
4 years, 8 months ago (2016-04-11 18:43:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2c77dbb976071c5185fca4ab475e72a2975b3993 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698