Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1865153003:
Add doc instructions for multi-repo Chromium trybots. (Closed)
|
Created:
4 years, 8 months ago by bungeman-skia Modified:
4 years, 8 months ago Reviewers:
dogben CC:
borenet, reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd doc instructions for multi-repo Chromium trybots.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1865153003
Committed: https://skia.googlesource.com/skia/+/ccb0de64f38d05522353fcdcbd51a063c1d29b08
Patch Set 1 #Patch Set 2 : 80 columns #Patch Set 3 : Escape pointy brackets? #Patch Set 4 : Some consistency. #Patch Set 5 : Add better way and examples. #
Total comments: 2
Messages
Total messages: 23 (13 generated)
Description was changed from ========== Add dec instructions for multi-repo Chromium trybots. ========== to ========== Add dec instructions for multi-repo Chromium trybots. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ==========
Description was changed from ========== Add dec instructions for multi-repo Chromium trybots. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ========== to ========== Add dec instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ==========
Description was changed from ========== Add dec instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ========== to ========== Add dec instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add dec instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add dec instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ==========
Description was changed from ========== Add dec instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ========== to ========== Add dec instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add dec instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add dec instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ==========
bungeman@google.com changed reviewers: + benjaminwagner@google.com
Since Ben was the last one other than me to want a way to do this, making him a reviewer. Eric, copying you since you don't like us checking in temporary branches.
Description was changed from ========== Add dec instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ========== to ========== Add doc instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ==========
lgtm Looks Gross To Me. I have it on my OKRs to get a Skia trybot for running Blink layout tests.
One suggestion: maybe add an example CL where you did this?
On 2016/04/07 14:47:29, Ben Wagner wrote: > lgtm > > Looks Gross To Me. > > I have it on my OKRs to get a Skia trybot for running Blink layout tests. The nice thing about this is it also works for non-Skia repos as well, though I suppose we don't often care that much now that Blink is in Chromium (don't need three repo changes that often anymore).
On 2016/04/07 at 16:06:26, bungeman wrote: > On 2016/04/07 14:47:29, Ben Wagner wrote: > > lgtm > > > > Looks Gross To Me. > > > > I have it on my OKRs to get a Skia trybot for running Blink layout tests. > > The nice thing about this is it also works for non-Skia repos as well, though I suppose we don't often care that much now that Blink is in Chromium (don't need three repo changes that often anymore). Understood. However, clicking a few buttons to start a trybot is a much lower barrier to entry.
Description was changed from ========== Add doc instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ========== to ========== Add doc instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add doc instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add doc instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ==========
On 2016/04/07 16:16:19, Ben Wagner wrote: > On 2016/04/07 at 16:06:26, bungeman wrote: > > On 2016/04/07 14:47:29, Ben Wagner wrote: > > > lgtm > > > > > > Looks Gross To Me. > > > > > > I have it on my OKRs to get a Skia trybot for running Blink layout tests. > > > > The nice thing about this is it also works for non-Skia repos as well, though > I suppose we don't often care that much now that Blink is in Chromium (don't > need three repo changes that often anymore). > > Understood. However, clicking a few buttons to start a trybot is a much lower > barrier to entry. I figured out a way to use your suggestion to just apply the rietveld patch, so I put that in this explanation first, since it's simpler, more straight forward, and lends itself to scripting or making a builder out of at some point.
The CQ bit was checked by bungeman@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from benjaminwagner@google.com Link to the patchset: https://codereview.chromium.org/1865153003/#ps80001 (title: "Add better way and examples.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865153003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865153003/80001
Message was sent while issue was closed.
Description was changed from ========== Add doc instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 ========== to ========== Add doc instructions for multi-repo Chromium trybots. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1865153003 Committed: https://skia.googlesource.com/skia/+/ccb0de64f38d05522353fcdcbd51a063c1d29b08 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/ccb0de64f38d05522353fcdcbd51a063c1d29b08
Message was sent while issue was closed.
https://codereview.chromium.org/1865153003/diff/80001/site/dev/chrome/multi_r... File site/dev/chrome/multi_repo_trybots.md (right): https://codereview.chromium.org/1865153003/diff/80001/site/dev/chrome/multi_r... site/dev/chrome/multi_repo_trybots.md:26: '--patchset', '160001', Maybe indicate that issue, patchset, and potentially server may need to be replaced? Also, for someone not familiar with Reitveld, it's not at all clear how to find the correct value for patchset.
Message was sent while issue was closed.
https://codereview.chromium.org/1865153003/diff/80001/site/dev/chrome/multi_r... File site/dev/chrome/multi_repo_trybots.md (right): https://codereview.chromium.org/1865153003/diff/80001/site/dev/chrome/multi_r... site/dev/chrome/multi_repo_trybots.md:26: '--patchset', '160001', On 2016/04/14 16:40:51, Ben Wagner wrote: > Maybe indicate that issue, patchset, and potentially server may need to be > replaced? Also, for someone not familiar with Reitveld, it's not at all clear > how to find the correct value for patchset. Eck, I actually wrote that but it appears I didn't save it. I'll add it. Unfortunately, Rietveld is quite bad at exposing the actual patchset number. |
