kiosk: Fix kiosk session restart

chrome/browser/chromeos/chrome_browser_main_chromeos.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/chrome_browser_main_chromeos.h"
 
 #include <stddef.h>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 514 matching lines @@
   ChromeBrowserMainPartsLinux::PreProfileInit();
 
   if (immediate_login) {
     const std::string cryptohome_id =
         parsed_command_line().GetSwitchValueASCII(switches::kLoginUser);
     const AccountId account_id(
         cryptohome::Identification::FromString(cryptohome_id).GetAccountId());
 
     user_manager::UserManager* user_manager = user_manager::UserManager::Get();
 
-    if (policy::IsDeviceLocalAccountUser(account_id.GetUserEmail(), NULL) &&
-        !user_manager->IsKnownUser(account_id)) {
+    if (policy::IsDeviceLocalAccountUser(account_id.GetUserEmail(), nullptr) &&
+        !user_manager->IsKnownUser(account_id) &&

[bartfab (slow), 2016/04/07 14:55:42]

Why is the kiosk user not a known user? We explicitly add public session users
to the known user list. Is it not just an oversight that we skip kiosk users?

[xiyuan, 2016/04/07 21:43:57]

Makes sense to make kiosk apps part of known users. I will do it as the fix.

+        !KioskAppManager::Get()->GetAppByAccountId(account_id, nullptr)) {
       // When a device-local account is removed, its policy is deleted from disk
       // immediately. If a session using this account happens to be in progress,
       // the session is allowed to continue with policy served from an in-memory
       // cache. If Chrome crashes later in the session, the policy becomes
       // completely unavailable. Exit the session in that case, rather than
       // allowing it to continue without policy.
       chrome::AttemptUserExit();
       return;
     }
 
@@ skipping 326 matching lines @@
   // Destroy DBus services immediately after threads are stopped.
   dbus_services_.reset();
 
   ChromeBrowserMainPartsLinux::PostDestroyThreads();
 
   // Destroy DeviceSettingsService after g_browser_process.
   DeviceSettingsService::Shutdown();
 }
 
 }  //  namespace chromeos