Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: extensions/renderer/dispatcher.cc

Issue 1865103002: Implement ExtensionView based on out-of-process iframes GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extensionoptions
Patch Set: addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/dispatcher.cc
diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc
index df828dcc4856a49e5c627612b396d2fcf7f4df75..ade98b8834cf1ff49d6acb19996875c0188aa092 100644
--- a/extensions/renderer/dispatcher.cc
+++ b/extensions/renderer/dispatcher.cc
@@ -1575,23 +1575,15 @@ void Dispatcher::RequireGuestViewModules(ScriptContext* context) {
Feature::Context context_type = context->context_type();
ModuleSystem* module_system = context->module_system();
- // Only set if |context| is capable of running guests in OOPIF. Used to
- // require additional module overrides.
- bool guest_view_required = false;
-
// Require AppView.
if (context->GetAvailability("appViewEmbedderInternal").is_available()) {
module_system->Require("appView");
-
- guest_view_required = true;
}
// Require ExtensionOptions.
if (context->GetAvailability("extensionOptionsInternal").is_available()) {
module_system->Require("extensionOptions");
module_system->Require("extensionOptionsAttributes");
-
- guest_view_required = true;
}
// Require ExtensionView.
@@ -1610,12 +1602,9 @@ void Dispatcher::RequireGuestViewModules(ScriptContext* context) {
.is_available()) {
module_system->Require("webViewExperimental");
}
-
- guest_view_required = true;
}
- if (guest_view_required &&
- content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests()) {
+ if (content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests()) {
module_system->Require("guestViewIframe");
module_system->Require("guestViewIframeContainer");
}
« no previous file with comments | « chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698