views: support vertical-drag-to-end on textfields

ui/views/controls/textfield/textfield_model.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield_model.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 383 matching lines @@
 
 bool TextfieldModel::MoveCursorTo(const gfx::Point& point, bool select) {
   if (HasCompositionText())
     ConfirmCompositionText();
   gfx::SelectionModel cursor = render_text_->FindCursorPosition(point);
   if (select)
     cursor.set_selection_start(render_text_->selection().start());
   return render_text_->MoveCursorTo(cursor);
 }
 
+void TextfieldModel::MoveCursorToStart(bool select) {

[tapted, 2016/04/06 23:29:38]

I think these are misleading "Start" could be left in LTR but right in RTL, but
in fact we always want geometric left or right, since it's based on the mouse
cursor position.

Perhaps just one method:

SelectLineFromCursor(gfx::VisualCursorDirection direction);

but I also have to ask whether we really need the separate method. It changes
the testing scene, but
 - the added tests are mostly redundant with the coverage in
TextfieldModelTest.Selection, and
 - we really should have a test at a higher level with platform-specifics in
textfield_unittest.cc that passes a mouse location

Perhaps we can just add a few lines to TextfieldTest.DragToSelect

(it has a drag_left/right, we can add a drag_up/down as well :).


Then, I think it's best for Textfield::SelectThroughLastDragLocation() to just
call MoveCursor(..) directly

[Elly Fong-Jones, 2016/04/07 17:43:47]

Okay, done and removed, and I added a unit test.

+  MoveCursor(gfx::BreakType::LINE_BREAK,
+             gfx::VisualCursorDirection::CURSOR_LEFT,
+             select);
+}
+
+void TextfieldModel::MoveCursorToEnd(bool select) {
+  MoveCursor(gfx::BreakType::LINE_BREAK,
+             gfx::VisualCursorDirection::CURSOR_RIGHT,
+             select);
+}
+
 base::string16 TextfieldModel::GetSelectedText() const {
   return text().substr(render_text_->selection().GetMin(),
                        render_text_->selection().length());
 }
 
 void TextfieldModel::SelectRange(const gfx::Range& range) {
   if (HasCompositionText())
     ConfirmCompositionText();
   render_text_->SelectRange(range);
 }
@@ skipping 360 matching lines @@
   ClearComposition();
   if (delete_from != delete_to)
     render_text_->SetText(old_text.erase(delete_from, delete_to - delete_from));
   if (!new_text.empty())
     render_text_->SetText(old_text.insert(new_text_insert_at, new_text));
   render_text_->SetCursorPosition(new_cursor_pos);
   // TODO(oshima): Select text that was just undone, like Mac (but not GTK).
 }
 
 }  // namespace views