Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1865013002: Quit creating array literal boilerplates from Crankshaft. (Closed)

Created:
4 years, 8 months ago by mvstanton
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Quit creating array literal boilerplates from Crankshaft. It's such a corner case. BUG= Committed: https://crrev.com/d72112161d36cbc257e8e7c19f4809495ef97208 Cr-Commit-Position: refs/heads/master@{#35346}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -47 lines) Patch
M src/crankshaft/hydrogen.cc View 3 chunks +14 lines, -38 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -5 lines 1 comment Download
M src/runtime/runtime-literals.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mvstanton
Hi Michael, here is the change we discussed. Jaro, can you look at hydrogen.cc? Thanks! ...
4 years, 8 months ago (2016-04-06 13:04:46 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1865013002/diff/1/src/runtime/runtime.h File src/runtime/runtime.h (left): https://codereview.chromium.org/1865013002/diff/1/src/runtime/runtime.h#oldcode1128 src/runtime/runtime.h:1128: // Used in runtime.cc and hydrogen's VisitArrayLiteral. Yay! ...
4 years, 8 months ago (2016-04-06 13:17:24 UTC) #3
mvstanton
gentle Jaro-ping.
4 years, 8 months ago (2016-04-07 15:17:00 UTC) #4
Benedikt Meurer
Awesome, LGTM!
4 years, 8 months ago (2016-04-08 05:35:52 UTC) #6
Jarin
lgtm
4 years, 8 months ago (2016-04-08 07:23:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865013002/1
4 years, 8 months ago (2016-04-08 07:58:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 08:22:27 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 08:24:16 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d72112161d36cbc257e8e7c19f4809495ef97208
Cr-Commit-Position: refs/heads/master@{#35346}

Powered by Google App Engine
This is Rietveld 408576698